This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Added changes to pass test cases#2
Open
faridjafri wants to merge 1 commit intoStateFarmInsCodingCompetition:mainfrom
Open
Added changes to pass test cases#2faridjafri wants to merge 1 commit intoStateFarmInsCodingCompetition:mainfrom
faridjafri wants to merge 1 commit intoStateFarmInsCodingCompetition:mainfrom
Conversation
|
From what I saw, getCustomersRetainedForYearsByPlcyCostAsc2 is just a missnamed test for getDependents |
Author
Right, but the expected values are still incorrect in the tests. I check the csv manually by filtering by parameters as described in the documentation. Did you get it right? |
|
@faridjafri Yes, I was able to get it correctly. I had a similar issue it might be related to the way you parse your dependents possibly. This was my solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have mentioned in feedback.txt, I think expected values for getCustomersRetainedForYearsByPlcyCostAsc2 are wrong in the test file.